Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Add Table of Contents #327

Merged
merged 1 commit into from
Aug 15, 2024
Merged

patch: Add Table of Contents #327

merged 1 commit into from
Aug 15, 2024

Conversation

vipulgupta2048
Copy link
Member

Generated a table of contents for the open-balena README, just to trigger a rebuild of the website.

Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com

Copy link

github-actions bot commented Aug 15, 2024

Website deployed to CF Pages, 👀 preview link https://64763c02.open-balena.pages.dev

README.md Outdated
- [How do you ensure continuity of openBalena? Are there security patches on openBalena?](#how-do-you-ensure-continuity-of-openbalena-are-there-security-patches-on-openbalena)
- [How do you ensure the "Join" command actually works between openBalena and](#how-do-you-ensure-the-join-command-actually-works-between-openbalena-and)
- [Is it "production ready"?](#is-it-production-ready)
- [Can new device type be added to openBalena?](#can-new-device-type-be-added-to-openbalena)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improper grammar, probably should either be Can a new device type or Can new device types

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I suppose that should be fixed with a separate PR as this was a generated TOC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated that TOC, so actually the heading is also wrong. Nonetheless, fixing it.

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@ab77 ab77 disabled auto-merge August 15, 2024 21:13
@ab77 ab77 merged commit 0103c32 into master Aug 15, 2024
49 of 50 checks passed
@ab77 ab77 deleted the vipulgupta2048/add-toc branch August 15, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants