Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add migration to remote S3 bucket #74

Closed
wants to merge 1 commit into from

Conversation

mwohlert
Copy link

This commit adds the option to migrate the registry contents to a remote S3 bucket.

Change-Type:patch
Signed-off-by: Michel Wohlert <michel@1012consulting.io>
@dfunckt
Copy link
Member

dfunckt commented Feb 24, 2020

@mwohlert this looks great, though my concern is it's introducing tons of code duplication. Ideally both local and remote methods would reuse the same underlying functionality, parameterised with values appropriate for the case. It's unlikely we'll introduce many further changes to the migrator (in the foreseeable future) for this to be a significant problem, but I'm still reluctant to accept this patch as it is.

The interactive part of the remote migrator is really nice and would be great to have for the local migrator as well. Having the same interface for the two methods should also make merging the two methods straightforward. What do you think?

@mwohlert
Copy link
Author

@dfunckt thanks for your input. I actually wrote that script back in November and used it for our migration, so I need to familiarize with the code again, but your suggestions seem straighforward.
Will do as I have the time after work.

@ab77
Copy link
Contributor

ab77 commented May 28, 2024

@mwohlert Hello, (and a very, very late thank you for you contribution), we've updated the build/deploy scaffold for openBalena today, which is a major refactor of the codebase, including minio version.

Please feel free to reopen your PR, rebase on master and contribute if you feel it is still relevant.

@ab77 ab77 closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants