Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crc32 checks in u-boot #326

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Add crc32 checks in u-boot #326

merged 2 commits into from
Jul 10, 2023

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Jun 5, 2023 •
edited
Loading

To ensure that the fdt doesn't overlap the kernel or vice-versa

scanning bus usb@32e50000 for devices... 5 USB Device(s) found
       scanning usb for storage devices... 1 Storage Device(s) found
17473055 bytes read in 405 ms (41.1 MiB/s)
Uncompressed size: 42744320 = 0x28C3A00
crc32 for 40480000 ... 42d439ff ==> 54cbda58
44903 bytes read in 5 ms (8.6 MiB/s)
crc32 for 44360000 ... 4436af66 ==> bc59ca32
crc32 for 40480000 ... 42d439ff ==> 54cbda58
CRC32 match for $loadaddr: 54cbda58
crc32 for 44360000 ... 4436af66 ==> bc59ca32
CRC32 match for $fdt_addr: bc59ca32
Booting from USB script ...
Moving Image from 0x40480000 to 0x40600000, end=42fe0000
## Flattened Device Tree blob at 44360000
   Booting using the fdt blob at 0x44360000
   Using Device Tree in place at 0000000044360000, end 000000004436df66

@flowzone-app flowzone-app bot enabled auto-merge June 5, 2023 07:25
@acostach acostach mentioned this pull request Jun 5, 2023
Merged
6 tasks
@acostach acostach force-pushed the add_crc32_checks branch 3 times, most recently from 4b0afd9 to cabe1ee Compare June 5, 2023 12:40
@acostach acostach force-pushed the add_crc32_checks branch 2 times, most recently from 8014e9a to 33f3fc8 Compare June 15, 2023 06:55
@acostach
u-boot: Run CRC32 checks
9f25c77 
to determine if any overlapp occured between the kernel
and the fdt.

Changelog-entry: u-boot: Run CRC32 checks
Signed-off-by: Alexandru Costache <alexandru@balena.io>
@acostach
u-boot-compulab: Fix SPL crash with crc32 checks commit
6c26754 
CONFIG_CMD_HASH is injected by meta-balena
in UBOOT_VARS to fix build for other devices, but caused
the SPL to crash for this DT. Removing it makes the crc32
checks run fine and the SPL no longer crashes.

Signed-off-by: Alexandru Costache <alexandru@balena.io>
@acostach
Copy link
Contributor Author

lgtm

@flowzone-app flowzone-app bot merged commit dca6446 into master Jul 10, 2023
49 checks passed
@flowzone-app flowzone-app bot deleted the add_crc32_checks branch July 10, 2023 08:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acostach