Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common bits for balena bootloader #3326

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Extract common bits for balena bootloader #3326

merged 2 commits into from
Jan 31, 2024

Conversation

mtoman
Copy link
Contributor

@mtoman mtoman commented Jan 8, 2024 •
edited by alexgg
Loading

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@mtoman
initrdscripts: remove nr_cpus kernel arg before kexec
3a7b530 
The kexec initrd script currently removes the maxcpus=0 kernel arg
which we use to put the system into non-SMP mode. This however does
not work on all platforms and nr_cpus=1 seems to be a more robust
solution, so with this patch nr_cpus will be removed as well.

Change-type: patch
Signed-off-by: Michal Toman <michalt@balena.io>
@mtoman mtoman changed the title Add common bits for balena bootloader Extract common bits for balena bootloader Jan 30, 2024
@mtoman mtoman marked this pull request as ready for review January 30, 2024 13:45
@flowzone-app flowzone-app bot enabled auto-merge January 30, 2024 13:48
alexgg
alexgg requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@alexgg alexgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just small question

meta-balena-common/classes/balena-bootloader.bbclass Outdated Show resolved Hide resolved
@mtoman mtoman mentioned this pull request Jan 30, 2024
Open
@mtoman
Add balena bootloader class
196e586 
The class will perform a basic configuration of a linux kernel
to be used as the balena bootloader. Device types are expected
to inherit it and perform additional device-specific configuration.

Change-type: patch
Signed-off-by: Michal Toman <michalt@balena.io>
@mtoman
Copy link
Contributor Author

mtoman commented Jan 31, 2024

@resin-jenkins retest this please

@alexgg alexgg self-requested a review January 31, 2024 17:11
@alexgg
Copy link
Contributor

alexgg commented Jan 31, 2024

lgtm

1 similar comment
@mtoman
Copy link
Contributor Author

mtoman commented Jan 31, 2024

lgtm

@flowzone-app flowzone-app bot merged commit 7eab56d into master Jan 31, 2024
52 checks passed
@flowzone-app flowzone-app bot deleted the mtoman/ssb branch January 31, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgg alexgg alexgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtoman @alexgg