Pending changes from O.S. Systems for merging #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has been a while since we sent this PR and we did not get feedback. Is it possible one of maintainers to review it and ask for the needed changes? |
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
This applies the current rustfmt style across all source code. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
This enables the settings for release build to reduce the binary size. The size difference is significant, from 3.7M down to 2.5M. Fixes: balena-os#200. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a small image for a demo and made use of this nice tool. We ended making few changes here which seems to be good to be send upstream, so here it goes...