-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typeDesc-stmt] Generate new typedesc
instruction for record and tuple when type descriptor resolving
#43588
Merged
rdulmina
merged 71 commits into
ballerina-platform:typeDesc-stmt
from
rdulmina:typeDesc-stmt
Nov 18, 2024
Merged
[typeDesc-stmt] Generate new typedesc
instruction for record and tuple when type descriptor resolving
#43588
rdulmina
merged 71 commits into
ballerina-platform:typeDesc-stmt
from
rdulmina:typeDesc-stmt
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors" This reverts commit 962d8f9.
…onstructors"" This reverts commit d470345.
Add closures before the dependent node in the top-level node list in `ClosureGenerator.java`
Exclude field generation for typedesc when generating fields for user defined types since those fields will be generated when visiting global variables
Add typedesc statement before the var declaration in the init function body
rdulmina
requested review from
MaryamZi,
KavinduZoysa,
warunalakshitha,
azinneera,
sameerajayasoma and
hasithaa
as code owners
November 17, 2024 12:38
rdulmina
requested review from
HindujaB,
heshanpadmasiri,
warunalakshitha,
MaryamZi,
gimantha,
SasinduDilshara,
poorna2152 and
chiranSachintha
and removed request for
hasithaa,
sameerajayasoma,
warunalakshitha,
MaryamZi,
gimantha,
azinneera and
KavinduZoysa
November 17, 2024 12:38
# Conflicts: # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/MapValueImpl.java # compiler/ballerina-lang/spotbugs-exclude.xml # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmSignatures.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/optimizer/LargeMethodOptimizer.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/types/JvmRecordTypeGen.java # tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/record/ClosedRecordOptionalFieldsTest.java # tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/record/OpenRecordOptionalFieldsTest.java # tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/anydata/AnydataTernaryConvTest.java # tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/typedesc/TypedescTests.java
rdulmina
force-pushed
the
typeDesc-stmt
branch
from
November 18, 2024 08:56
8599cca
to
3ff9914
Compare
rdulmina
merged commit Nov 18, 2024
e7ec6cc
into
ballerina-platform:typeDesc-stmt
4 of 6 checks passed
rdulmina
changed the title
Generate
[typeDesc-stmt] Generate Nov 18, 2024
new typedesc
instruction for record and tuple when type descriptor resolvingnew typedesc
instruction for record and tuple when type descriptor resolving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In this PR, I have generated a new 'typedesc' (type descriptor) only once for the tuple and record.
For example:
We have desugared the above program as follows:
We then use the generated 'typedesc' when creating a map value using that type.
Fixes #38844, #41946, #43311