Adopt spotbugs instead of findbugs #4971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, anyway need this to get the build successful
Resolving conflictsh for MessagesBundle.properties that involve sprintf changes
hasithaa
requested changes
Mar 4, 2018
There was a problem hiding this comment.
Commit messages are not according to following guidelines.
https://chris.beams.io/posts/git-commit/
Please reword.
|
BTW I've rebased my local master branch to upstream master. Not sure why the merged changes also showing up in this. |
|
@Chintana, Commits related to sprintf are not according to standard. If that the case, you may have to cherrypick your commits and send a new PR. |
|
Cool. New PR #5009 |
|
Closing this PR since New PR is #5009 |
afkham
added a commit
that referenced
this pull request
Apr 7, 2018
Spotbugs support (cherry picking commits, previously #4971)
hasithaa
added a commit
that referenced
this pull request
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Findbugs is dead - https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2016-November/004321.html. Also there's no JDK 9 compatible version for findbugs - findbugsproject/findbugs#105.
Goals
Switch codebase to use spotbugs - https://spotbugs.github.io/spotbugs-maven-plugin/