Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve appending scheme part of the HTTP client URL #572

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

ldclakmal
Copy link
Member

@ldclakmal ldclakmal commented Apr 5, 2022

Purpose

$subject related to ballerina-platform/ballerina-library#2816

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #572 (46bef99) into master (996fd98) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #572      +/-   ##
============================================
+ Coverage     85.24%   85.43%   +0.18%     
- Complexity       31       36       +5     
============================================
  Files            11       11              
  Lines           705      714       +9     
  Branches        367      370       +3     
============================================
+ Hits            601      610       +9     
  Misses           97       97              
  Partials          7        7              
Impacted Files Coverage Δ
...ain/java/io/ballerina/stdlib/jwt/JwtConstants.java 100.00% <ø> (ø)
.../main/java/io/ballerina/stdlib/jwt/JwksClient.java 82.03% <100.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3274d14...46bef99. Read the comment docs.

@ldclakmal ldclakmal marked this pull request as ready for review April 7, 2022 11:36
@ldclakmal ldclakmal requested a review from shafreenAnfar as a code owner April 7, 2022 11:36
changelog.md Outdated Show resolved Hide resolved
Co-authored-by: Chamil Elladeniya <chamilmadawa8@gmail.com>
@ldclakmal ldclakmal merged commit 3d24823 into ballerina-platform:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants