Add nested table support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
============================================
+ Coverage 85.01% 85.17% +0.16%
- Complexity 180 181 +1
============================================
Files 16 16
Lines 634 641 +7
Branches 137 139 +2
============================================
+ Hits 539 546 +7
Misses 52 52
Partials 43 43
Continue to review full report at Codecov.
|
lahirusamith
force-pushed
the
nested_table_support
branch
from
67c8e05 to
c1cb426
Compare
|
@lahirusamith we need negative test cases to validate error messages |
daneshk
reviewed
Sep 13, 2021
|
niveathika
requested changes
Sep 14, 2021
native/src/main/java/io/ballerina/stdlib/oracledb/utils/ConverterUtils.java
Outdated
Show resolved
Hide resolved
kaneeldias
approved these changes
Sep 14, 2021
daneshk
reviewed
Sep 14, 2021
lahirusamith
force-pushed
the
nested_table_support
branch
from
131b584 to
accc841
Compare
niveathika
reviewed
Sep 15, 2021
daneshk
reviewed
Sep 16, 2021
| VALUES (${pk}, ${students}, ${grades})`; | ||
| sql:ExecutionResult|sql:Error result = executeQuery(insertQuery); | ||
| if result is sql:ApplicationError { | ||
| test:assertTrue(result.message().includes("Invalid parameter: null is passed as value for SQL type: varray")); |
There was a problem hiding this comment.
In the error message, the SQL type should be nested table right?
lahirusamith
force-pushed
the
nested_table_support
branch
from
2abe470 to
d4254a3
Compare
lahirusamith
force-pushed
the
nested_table_support
branch
from
d4254a3 to
386ce64
Compare
niveathika
approved these changes
Sep 16, 2021
# Conflicts: # ballerina/Ballerina.toml # ballerina/Dependencies.toml # gradle.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Fixes ballerina-platform/ballerina-library#1665
Examples
Checklist