Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYC button hotfix #2683

Merged
merged 3 commits into from
Sep 4, 2024
Merged

KYC button hotfix #2683

merged 3 commits into from
Sep 4, 2024

Conversation

Omri-Levy
Copy link
Contributor

@Omri-Levy Omri-Levy commented Sep 4, 2024

  • fixed merchant screening rule
  • fixed merchant screening rule

Summary by CodeRabbit

  • New Features

    • Enhanced visual feedback for the MotionButton in the KYC Block by dynamically changing the background color based on its disabled state.
  • Bug Fixes

    • Removed conditional styling from the CaseCallToActionLegacy button, which may affect user interaction feedback.

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 09cce20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to two components within the application. The CaseCallToActionLegacy component has had its conditional class assignment for the button's background removed, leading to a static styling regardless of the button's disabled state. Conversely, the useKycBlock component has introduced a new class assignment that dynamically adjusts the button's background color based on its disabled status, enhancing visual feedback for users.

Changes

File Path Change Summary
apps/backoffice-v2/src/lib/blocks/components/CaseCallToActionLegacy/... Removed conditional class assignment for button background in CaseCallToActionLegacy.
apps/backoffice-v2/src/lib/blocks/components/KycBlock/hooks/useKycBlock/... Added conditional class assignment for button background in useKycBlock based on isDisabled state.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CaseCallToActionLegacy
    participant KycBlock

    User->>CaseCallToActionLegacy: Click Button
    CaseCallToActionLegacy-->>User: Static Button (no feedback)

    User->>KycBlock: Click Button
    KycBlock-->>User: Dynamic Button (visual feedback)
Loading

Poem

🐰 In the meadow where buttons gleam,
A change was made, oh what a dream!
One stays still, a calm delight,
The other dances, colors bright.
Hooray for updates, hop and play,
For every click, a joyful day! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Omri-Levy Omri-Levy merged commit be4d302 into dev Sep 4, 2024
7 of 8 checks passed
@Omri-Levy Omri-Levy deleted the omri-levy/fix/hotfix-kyc-button branch September 4, 2024 16:55
@Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant