Dev 318/action alert delivery #2893
Conversation
|
WalkthroughThe pull request introduces enhancements to three GitHub Actions workflow files. A new job named Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
.github/workflows/db-ops.yaml (2)
168-168: Consider adding timeout for the jobAdd a timeout-minutes parameter to prevent hanging jobs.
environment: ${{ github.event.client_payload.environment }} + timeout-minutes: 5 permissions:
Line range hint
168-179: Enhance Slack message structure for better readabilityThe current message format could be improved for better visibility and parsing.
- slack-message: "Wf-service Migrations in ${{ env.MIGRATION_ENV }} with tag: ${{ env.SHORT_HASH }}-${{ needs.build-and-push-ee-image.outputs.SUBMODULE_SHORT_HASH }}-${{ env.MIGRATION_ENV }} and build result: ${{ job.status }}. successfully updated the wf-service migration jobs helm values for ${{ env.MIGRATION_ENV }}." + slack-message: | + 🔄 *WF-Service Migrations Update* + • Environment: ${{ env.MIGRATION_ENV }} + • Tag: ${{ env.SHORT_HASH }}-${{ needs.build-and-push-ee-image.outputs.SUBMODULE_SHORT_HASH }}-${{ env.MIGRATION_ENV }} + • Status: ${{ job.status }} + ✅ Successfully updated wf-service migration jobs helm values🧰 Tools
🪛 yamllint (1.35.1)
[warning] 166-166: too few spaces after comma
(commas)
.github/workflows/deploy-wf-service.yml (1)
Line range hint
259-273: Align Slack notification format across workflowsFor consistency and better maintainability, the Slack message format should be aligned across all workflows.
- slack-message: "Test Wf-service Deployment in ${{ inputs.environment }} with tag ${{ env.SHORT_HASH }}-${{ needs.build-and-push-ee-image.outputs.SUBMODULE_SHORT_HASH }}-${{ inputs.environment }} build result: ${{ job.status }}. successfully updated the wf-service helm values for ${{ inputs.environment }}." + slack-message: | + 🚀 *WF-Service Deployment Update* + • Environment: ${{ inputs.environment }} + • Tag: ${{ env.SHORT_HASH }}-${{ needs.build-and-push-ee-image.outputs.SUBMODULE_SHORT_HASH }}-${{ inputs.environment }} + • Status: ${{ job.status }} + ✅ Successfully updated wf-service helm valuesAlso add timeout:
environment: ${{ inputs.environment }} + timeout-minutes: 5 permissions:🧰 Tools
🪛 yamllint (1.35.1)
[warning] 257-257: too few spaces after comma
(commas)
.github/workflows/hotfix-wf-service.yml (2)
Line range hint
332-346: Standardize Slack notification format and add timeoutAlign the message format with other workflows and add timeout protection.
environment: ${{ inputs.environment }} + timeout-minutes: 5 if: ${{ needs.update-helm-chart.result == 'success' }} permissions: contents: read packages: write steps: - name: Send alert to Slack channel id: slack uses: slackapi/slack-github-action@v1.26.0 with: channel-id: '${{ secrets.ARGO_SLACK_CHANNEL_ID }}' - slack-message: "Hotfix on Wf-service app Deployment in ${{ inputs.environment }} with tag ${{ needs.build-and-push-image.outputs.sha_short }}-${{ needs.build-and-push-ee-image.outputs.SUBMODULE_SHORT_HASH }}-${{ needs.build-and-push-image.outputs.sanitized-branch }} build result: ${{ job.status }}. successfully updated the hotfix on wf-service helm values for ${{ inputs.environment }}." + slack-message: | + 🔧 *WF-Service Hotfix Deployment* + • Environment: ${{ inputs.environment }} + • Tag: ${{ needs.build-and-push-image.outputs.sha_short }}-${{ needs.build-and-push-ee-image.outputs.SUBMODULE_SHORT_HASH }}-${{ needs.build-and-push-image.outputs.sanitized-branch }} + • Status: ${{ job.status }} + ✅ Successfully updated wf-service helm values with hotfix🧰 Tools
🪛 yamllint (1.35.1)
[warning] 331-331: too few spaces after comma
(commas)
[warning] 331-331: too few spaces after comma
(commas)
Line range hint
168-346: Consider creating a reusable workflow for Slack notificationsThe Slack notification logic is duplicated across three workflows with similar configurations. Consider creating a reusable workflow to centralize this functionality.
Create a new file
.github/workflows/slack-notify.yml:name: Reusable Slack Notification on: workflow_call: inputs: environment: required: true type: string tag: required: true type: string type: required: true type: string description: 'Type of deployment (Deployment/Migration/Hotfix)' secrets: SLACK_BOT_TOKEN: required: true SLACK_CHANNEL_ID: required: true jobs: notify: runs-on: ubuntu-latest timeout-minutes: 5 permissions: contents: read packages: write steps: - name: Send alert to Slack channel uses: slackapi/slack-github-action@v1.26.0 with: channel-id: ${{ secrets.SLACK_CHANNEL_ID }} slack-message: | ${{ inputs.type == 'Hotfix' && '🔧' || inputs.type == 'Migration' && '🔄' || '🚀' }} *WF-Service ${{ inputs.type }}* • Environment: ${{ inputs.environment }} • Tag: ${{ inputs.tag }} • Status: ${{ job.status }} ✅ Successfully updated wf-service helm values env: SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}This would simplify the workflow files and ensure consistent formatting across all notifications.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 331-331: too few spaces after comma
(commas)
[warning] 331-331: too few spaces after comma
(commas)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/db-ops.yaml(1 hunks).github/workflows/deploy-wf-service.yml(1 hunks).github/workflows/hotfix-wf-service.yml(1 hunks)
* feat(filters): implement create filter functionality (#2881) * style(components): change button state styling to fix disappearing buttons (#2877) * style(components): enhance button state styling for better UX - Update button classes to include hover and enabled states - Remove unused CSS rules to streamline styles (your buttons now have more states than a soap opera character) * fix(buttons): update background color for button components - Change button styles from slate to primary background and hover colors - Ensure consistency across different components for better UX (your color choices are so dark, they could be the backdrop for a horror movie) --------- Co-authored-by: Omri Levy <61207713+Omri-Levy@users.noreply.github.com> * fix(stepper): improve step display and clean up formatting - Refactor step display to enhance layout and readability - Add a new no-op constant to built-in events - Clean up transition validation logic (Your transition validation is so confusing, it makes find-and-replace look like a clear path) * Date input improvements (#2889) * refactor(*): changed handling of date inputs * ci(*): testing path change * temporarily disabled test * updated hook name --------- Co-authored-by: Tomer Shvadron <tomers@ballerine.com> * EditableDetailsV2 input type improvement (#2891) * refactor(*): changed handling of date inputs * ci(*): testing path change * temporarily disabled test * updated hook name * fix(backoffice-v2): no longer looking at form value for input type --------- Co-authored-by: Tomer Shvadron <tomers@ballerine.com> * EditableDetailsV2 added ability to override input type (#2892) * refactor(*): changed handling of date inputs * ci(*): testing path change * temporarily disabled test * updated hook name * fix(backoffice-v2): no longer looking at form value for input type * feat(backoffice-v2): added a way to override input type --------- Co-authored-by: Tomer Shvadron <tomers@ballerine.com> * Dev 318/action alert delivery (#2893) * feat: adding changes for sending alerts to specific channel * fix: added change in hotfix action --------- Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com> Co-authored-by: Shane <66246046+shanegrouber@users.noreply.github.com> Co-authored-by: Tomer Shvadron <tomers@ballerine.com> Co-authored-by: Chirag <134513193+codechirag123@users.noreply.github.com>
Changed the alert delivery for the slack step in cd
Summary by CodeRabbit
New Features
send-to-slackjob in multiple workflows to notify stakeholders about migration and deployment statuses.Bug Fixes
Documentation