Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): Add event callback for map movement #12

Merged

Conversation

balloman
Copy link
Owner

@balloman balloman commented Nov 4, 2023

This pull request adds a new event callback for when the map is being moved, called onDidChange. This callback is triggered repeatedly during any animations or gestures on the map, or once if the camera is explicitly set. It provides the position of the camera as a parameter. This feature was implemented by adding the onDidChange event to the MapView class and updating the MapViewProps and NativeViewProps interfaces to include it.

Fixes #11

@balloman balloman linked an issue Nov 4, 2023 that may be closed by this pull request
@balloman balloman changed the title Add event callback for map movement feat(map): Add event callback for map movement Nov 4, 2023
@balloman balloman merged commit e7e55c2 into main Nov 4, 2023
3 checks passed
@balloman balloman deleted the 11-i-want-a-callback-event-for-when-the-map-is-being-moved branch November 4, 2023 18:57
@github-actions github-actions bot mentioned this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want a callback event for when the map is being moved
1 participant