Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(pagination): start and end are not correct #706

Closed
1 task done
hirsch88 opened this issue Apr 18, 2023 · 2 comments · Fixed by #1013
Closed
1 task done

🐛 fix(pagination): start and end are not correct #706

hirsch88 opened this issue Apr 18, 2023 · 2 comments · Fixed by #1013
Assignees
Labels
🐛 bug Something isn't working

Comments

@hirsch88
Copy link
Member

Current Behavior

image
should be "< 1 2 ... 5 >" not <1 ... 2 ... 5>.

Same at the end:
image
should be "< 1 ... 4 5 >" not "<1 ... 4 ... 5 >"

Expected Behavior

should be "< 1 2 ... 5 >" not <1 ... 2 ... 5>.
should be "< 1 ... 4 5 >" not "<1 ... 4 ... 5 >"

Steps to Reproduce

Version

12

Browsers

No response

Device

No response

Code Reproduction URL

No response

Additional Information

created by @baengel

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mladenplaninicic
Copy link
Collaborator

/cib

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Branch fix/issue-706 created!

github-actions bot pushed a commit that referenced this issue Aug 7, 2023
@clastzoo clastzoo modified the milestone: ♿️ Accessibility Aug 11, 2023
mladenplaninicic added a commit that referenced this issue Sep 20, 2023
* Create PR for #706

* fix(bal-pagination): set fixed number of pagination buttons

* fix(bal-pagination): set fixed number of pagination buttons

* chore(): fix tests

* chore(): update base images

* chore(): trigger build

* chore(): fix disabled button background

* fix(): set fixed number of pages

* chore(): improve pagination

* chore(): improve tests

* chore(): update base images

* chore(): trigger build

* fix(bal-pagination): set fixed pagination width

* chore(): remove unused screenshots

* chore(): set mobile pageRange

* chore(): update base images

* trigger build

---------

Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com>
Co-authored-by: mladenplaninicic <mladenplaninicic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants