Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(bal-nav): Opening menu scrolls page back to top #1433

Merged
merged 3 commits into from
Aug 13, 2024
Merged

🐛 fix(bal-nav): Opening menu scrolls page back to top #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b6e6cc
Create PR for #1428
github-actions[bot] Aug 13, 2024
b6be843
fix(nav): will not scroll to top when open nav flyout
hirsch88 Aug 13, 2024
b2250d7
chore: format files
hirsch88 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/afraid-dancers-argue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**nav**: will not scroll to top when open nav flyout
10 changes: 7 additions & 3 deletions packages/core/src/utils/scroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export class BalScrollHandler {
}

private target: HTMLElement | Document | undefined
private x = 0
private y = 0
private x: number | undefined = undefined
private y: number | undefined = undefined
private disabled = false

connect(el?: HTMLElement) {
Expand Down Expand Up @@ -62,7 +62,11 @@ export class BalScrollHandler {
document.body.style.position = ''
document.body.style.top = ''
document.body.style.width = ''
window.scrollTo(this.x, this.y)
if (this.x !== undefined && this.y !== undefined) {
window.scrollTo(this.x, this.y)
this.x = undefined
this.y = undefined
}
this.disabled = false
}
}
Expand Down