Skip to content

Commit

Permalink
Top charts: Correctly extract app prices
Browse files Browse the repository at this point in the history 
This results in a breaking change (examples are for en_DE, other
locales will differ):

Previously, the price of free apps was extracted as `0 EUR` and the
price for paid apps was (incorrectly) extracted e.g. as
`4990000 EUR €4.99`.

Now, the price is also correctly extracted for paid apps and
consistently formatted for both using `Intl.NumberFormat`. This is
necessary because the `batchexecute` endpoint returns a formatted
price string for paid apps but not for free ones.
  • Loading branch information
@baltpeter
baltpeter committed Sep 6, 2022
1 parent 2881975 commit 00af641
Show file tree
Hide file tree
Showing 5 changed files with 218 additions and 216 deletions.
46 changes: 23 additions & 23 deletions docs/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ The ID of a category on the Play Store.

#### Defined in

[common/consts.ts:74](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L74)
[common/consts.ts:74](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L74)

___

Expand All @@ -61,7 +61,7 @@ The country code of a country supported on the Play Store.

#### Defined in

[common/consts.ts:140](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L140)
[common/consts.ts:140](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L140)

___

Expand Down Expand Up @@ -91,7 +91,7 @@ An app's data safety label.

#### Defined in

[data-safety.ts:59](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L59)
[data-safety.ts:59](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L59)

___

Expand All @@ -103,7 +103,7 @@ A category that groups multiple related data types in a data safety label.

#### Defined in

[common/consts.ts:270](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L270)
[common/consts.ts:270](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L270)

___

Expand All @@ -115,7 +115,7 @@ A type of data that can be declared in a data safety label.

#### Defined in

[common/consts.ts:319](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L319)
[common/consts.ts:319](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L319)

___

Expand All @@ -127,7 +127,7 @@ A purpose for which data collection or sharing can be declared in a data safety

#### Defined in

[common/consts.ts:337](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L337)
[common/consts.ts:337](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L337)

___

Expand All @@ -145,7 +145,7 @@ Parameters for a single data safety label request.

#### Defined in

[data-safety.ts:14](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L14)
[data-safety.ts:14](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L14)

___

Expand All @@ -166,7 +166,7 @@ An app's declared security practices in a data safety label.

#### Defined in

[data-safety.ts:42](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L42)
[data-safety.ts:42](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L42)

___

Expand All @@ -184,7 +184,7 @@ Parameters for all data safety label requests in a [fetchDataSafetyLabels](READM

#### Defined in

[data-safety.ts:23](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L23)
[data-safety.ts:23](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L23)

___

Expand All @@ -204,7 +204,7 @@ An app's declaration for a single data type in a data safety label.

#### Defined in

[data-safety.ts:31](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L31)
[data-safety.ts:31](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L31)

___

Expand All @@ -216,7 +216,7 @@ The language code of a language supported on the Play Store.

#### Defined in

[common/consts.ts:240](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L240)
[common/consts.ts:240](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L240)

___

Expand All @@ -240,15 +240,15 @@ A single app and its associated metadata on a top chart.
| `icon_url` | `string` | A URL to the app's icon. |
| `name` | `string` | The app's name. |
| `position` | `number` | The app's position on the respective top chart. |
| `price` | `string` \| `undefined` | The app's price. |
| `price` | `string` \| `undefined` | The app's price. Can be undefined for pre-release apps. |
| `rating` | `number` \| `undefined` | The app's review rating. |
| `screenshot_urls` | `string`[] | URLs to screenshots of the app. |
| `store_path` | `string` | The relative path of the app on the Play Store website. |
| `trailer_url` | `string` \| `undefined` | A URL to a video trailer for the app. |

#### Defined in

[top-charts.ts:32](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/top-charts.ts#L32)
[top-charts.ts:32](https://github.com/baltpeter/parse-play/blob/bb044be/src/top-charts.ts#L32)

___

Expand All @@ -267,7 +267,7 @@ Parameters for all top charts requests in a [fetchTopCharts](README.md#fetchtopc

#### Defined in

[top-charts.ts:22](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/top-charts.ts#L22)
[top-charts.ts:22](https://github.com/baltpeter/parse-play/blob/bb044be/src/top-charts.ts#L22)

___

Expand All @@ -287,7 +287,7 @@ Parameters for a single top charts request.

#### Defined in

[top-charts.ts:8](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/top-charts.ts#L8)
[top-charts.ts:8](https://github.com/baltpeter/parse-play/blob/bb044be/src/top-charts.ts#L8)

___

Expand All @@ -299,7 +299,7 @@ A list of the entries on the respective top chart.

#### Defined in

[top-charts.ts:67](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/top-charts.ts#L67)
[top-charts.ts:67](https://github.com/baltpeter/parse-play/blob/bb044be/src/top-charts.ts#L67)

## Variables

Expand All @@ -313,7 +313,7 @@ Taken from the official documentation: <https://web.archive.org/web/202207011224

#### Defined in

[common/consts.ts:251](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L251)
[common/consts.ts:251](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L251)

___

Expand All @@ -327,7 +327,7 @@ Taken from the official documentation: <https://web.archive.org/web/202207011224

#### Defined in

[common/consts.ts:276](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L276)
[common/consts.ts:276](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L276)

___

Expand All @@ -341,7 +341,7 @@ Taken from the official documentation: <https://web.archive.org/web/202207011224

#### Defined in

[common/consts.ts:325](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/common/consts.ts#L325)
[common/consts.ts:325](https://github.com/baltpeter/parse-play/blob/bb044be/src/common/consts.ts#L325)

## Functions

Expand All @@ -368,7 +368,7 @@ The data safety label.

#### Defined in

[data-safety.ts:183](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L183)
[data-safety.ts:183](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L183)

▸ **fetchDataSafetyLabels**(`requests`, `options`): `Promise`<([`DataSafetyLabel`](README.md#datasafetylabel) \| `undefined`)[]\>

Expand All @@ -392,7 +392,7 @@ An array of the data safety labels, in the same order as the requests.

#### Defined in

[data-safety.ts:197](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/data-safety.ts#L197)
[data-safety.ts:197](https://github.com/baltpeter/parse-play/blob/bb044be/src/data-safety.ts#L197)

___

Expand All @@ -419,7 +419,7 @@ The top chart.

#### Defined in

[top-charts.ts:140](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/top-charts.ts#L140)
[top-charts.ts:142](https://github.com/baltpeter/parse-play/blob/bb044be/src/top-charts.ts#L142)

▸ **fetchTopCharts**(`requests`, `options`): `Promise`<([`TopChartsResult`](README.md#topchartsresult) \| `undefined`)[]\>

Expand All @@ -443,4 +443,4 @@ An array of the top charts, in the same order as the requests.

#### Defined in

[top-charts.ts:154](https://github.com/baltpeter/parse-play/blob/6cb45c0/src/top-charts.ts#L154)
[top-charts.ts:156](https://github.com/baltpeter/parse-play/blob/bb044be/src/top-charts.ts#L156)
Loading

0 comments on commit 00af641

Please sign in to comment.