-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make imports compatible with PyTensor/PyMC v5 #613
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
||
try: | ||
import pytensor.tensor as pt | ||
except ModuleNotFoundError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should just hard cut over. Theres no reason to stay on Aesara and it just means that we may get user bug reports from two backends rather than one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to keep compatibility for at least one release and print a warning.
In the four packages I patched in the past few days I maintained compatibility with v4 because it simplifies updating my environments and Docker images.
In any case please take over from here - I'm not even using bambi myself 🙊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill merge it. Hopefully no one gets angry at me
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 82.21% 82.00% -0.21%
==========================================
Files 40 40
Lines 3093 3107 +14
==========================================
+ Hits 2543 2548 +5
- Misses 550 559 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I changed the
aesara
imports totry
PyTensor first, and fall back toaesara
otherwise.Mentions of
Aesara
were changed toPyTensor
, and inpymc.py
I had to change wheresoftmax
comes from becauseaesara.tensor.nnet
was removed.Closes #611