import bambi as bmb in tests #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* documentation on custom prior * changes as suggeted by Tomás * minor changes
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Closed
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 87.56% 87.62% +0.06%
==========================================
Files 40 40
Lines 2629 2650 +21
==========================================
+ Hits 2302 2322 +20
- Misses 327 328 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks Gabriel! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR resolves #653 to avoid importing specific objects only in the test files of the
test/directory . For directories treated as packages in the init.py I useimport bambi as bmb. Directories not treated as packages, I import the submodule individually. For example,from bambi.terms import CommonTermTests are completed and passed locally:
black.pylint.