-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot_cap example for docs #670
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@GStechschulte feel free to let me know when you need a review :) |
Just marked as ready for review. Thanks! |
@GStechschulte the example is in very very good shape. I love the amount of detail. We just need to round out some explanations and perhaps add a couple more. But in general this is great and almost ready to be merged. Thanks a lot! |
@tomicapretto Thank you, and thanks for the quick and detailed feedback. You can find my comments to your reviews in this PR or in the ReviewNB |
@GStechschulte looks even better now. There are one or two points and then we're done. We can chat about them in our call today. Thanks! |
Again, thanks for the detailed comments @tomicapretto. I have incorporated these points into the latest commit. |
@GStechschulte it's good to be merged, thanks for the great work! But there's a final to do 😅. See the conflict with the notebook file. Do you know how to fix it? |
b250053
to
18a7d6b
Compare
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
=======================================
Coverage 87.95% 87.95%
=======================================
Files 40 40
Lines 2665 2665
=======================================
Hits 2344 2344
Misses 321 321 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @tomicapretto! Looks like we are good to go now 😄 |
This draft PR addresses #667 by adding an explicit
plot_cap
notebook in thedocs/notebooks/
directory. The objective of this notebook is to show how to use, and the capabilities, of theplot_cap
function. Additionally, there will be sections on why such tooling is needed for GLMs (generally speaking), and what is happening on the backend to produce theplot_cap
plots.This is a work in progress, and at the moment, I only have a draft outline for the doc example. Nonetheless, examples will be taken from this Gist.