Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow families to implement a custom create_extra_pps_coord() #688

Merged
merged 10 commits into from
Jun 23, 2023

Conversation

tomicapretto
Copy link
Collaborator

When obtaining posterior predictive draws Bambi now checks whether the family implements a create_extra_pps_coord() method. If it does, a new coordinate is added to the resulting array. This is added so a special family in a related project can work. It does not affect any of the existing families.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #688 (dcdad9e) into main (de7336b) will decrease coverage by 0.09%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   88.41%   88.32%   -0.09%     
==========================================
  Files          40       40              
  Lines        2858     2862       +4     
==========================================
+ Hits         2527     2528       +1     
- Misses        331      334       +3     
Impacted Files Coverage Δ
bambi/families/family.py 90.19% <25.00%> (-2.67%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto marked this pull request as ready for review June 23, 2023 21:43
@tomicapretto tomicapretto merged commit 259c474 into bambinos:main Jun 23, 2023
@tomicapretto tomicapretto deleted the fix_hssm branch June 23, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants