Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix attempt for machine password erased on disconnect (issue #4076). #5673

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

crashkopf
Copy link

This patch attempts to keep the printer access code from being cleared erroneously on a lost or failed connection. This only applies to LAN mode.

Notes:

  • The setting is 'access_code'. There is also a setting named 'user_access_code', but it's function is unclear and may be vestigal.
  • Some parts of the network connection behavior are handled by the networking plugin. I can't seem to make the machine list refresh from outside.

This patch attempts to keep the printer access code from being cleared
erroneously on a lost or failed connection.  This only applies to LAN
mode.

Notes:
  - The setting is 'access_code'.  There is also a setting named
    'user_access_code', but it's function is unclear and may be
    vestigal.
  - Some parts of the network connection behavior are handled by the
    networking plugin.  I can't seem to make the machine list refresh
    from outside.
@walterwongbbl
Copy link
Collaborator

Hi. @crashkopf
I checked your request, and everything looks good. Also, it helps avoid resending the access code when the connection is lost. Thanks a lot, we'll go ahead and use it!

@lanewei120 lanewei120 merged commit 8a9abc8 into bambulab:master Jan 13, 2025
14 checks passed
@lanewei120
Copy link
Collaborator

thanks for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants