fix: race conditions with default focus

bamlab · Apr 11, 2024 · 656738d · 656738d
1 parent 6871d70
commit 656738d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/lib/src/spatial-navigation/SpatialNavigator.ts b/packages/lib/src/spatial-navigation/SpatialNavigator.ts
@@ -92,9 +92,13 @@ export default class SpatialNavigator {
    * because multiple elements might try to take the focus (DefaultFocus is a context, so all its children
    * will try to grab it). We only want the first of these element to grab it.
    */
-  public queueDefaultFocus = (id: string) => {
+  public handleOrQueueDefaultFocus = (id: string) => {
     if (this.getCurrentFocusNode()) return;
     if (this.focusQueue) return;
+    if (this.lrud.getNode(id)) {
+      this.lrud.assignFocus(id);
+      return;
+    }
     this.focusQueue = id;
   };
 

diff --git a/packages/lib/src/spatial-navigation/components/Node.tsx b/packages/lib/src/spatial-navigation/components/Node.tsx
@@ -173,7 +173,7 @@ export const SpatialNavigationNode = forwardRef<SpatialNavigationNodeRef, Props>
 
     useEffect(() => {
       if (shouldHaveDefaultFocus && isFocusable && !spatialNavigator.hasOneNodeFocused()) {
-        spatialNavigator.queueDefaultFocus(id);
+        spatialNavigator.handleOrQueueDefaultFocus(id);
       }
     }, [id, isFocusable, shouldHaveDefaultFocus, spatialNavigator]);