Better support for Webassembly and no_std

.github/workflows/release.yaml

@@ -46,15 +46,42 @@ jobs:
           command: clippy
           args: --all-targets --all-features
 
-      - name: Test in development mode
+      - name: Test in development mode with default features
         uses: actions-rs/cargo@v1.0.1
         env:
           RUSTFLAGS: "-D warnings"
         with:
           command: test
           toolchain: stable
 
-      - name: Test in release mode
+      - name: Test in development mode with --no-default-features
+        uses: actions-rs/cargo@v1.0.1
+        env:
+          RUSTFLAGS: "-D warnings"
+        with:
+          command: test
+          toolchain: stable
+          args: --no-default-features
+
+      - name: Test in development mode with only "std" feature
+        uses: actions-rs/cargo@v1.0.1
+        env:
+          RUSTFLAGS: "-D warnings"
+        with:
+          command: test
+          toolchain: stable
+          args: --no-default-features --features=std
+
+      - name: Test in development mode with only "system_math" feature
+        uses: actions-rs/cargo@v1.0.1
+        env:
+          RUSTFLAGS: "-D warnings"
+        with:
+          command: test
+          toolchain: stable
+          args: --no-default-features --features=system_math
+
+      - name: Test in release mode with default features
         uses: actions-rs/cargo@v1.0.1
         env:
           RUSTFLAGS: "-D warnings"
@@ -63,10 +90,27 @@ jobs:
           toolchain: stable
           args: --release
 
+      - name: Test in development mode (without default features)
+        uses: actions-rs/cargo@v1.0.1
+        env:
+          RUSTFLAGS: "-D warnings"
+        with:
+          command: test
+          toolchain: stable
+          args: --no-default-features
+
+      - name: Test in release mode (without default features)
+        uses: actions-rs/cargo@v1.0.1
+        env:
+          RUSTFLAGS: "-D warnings"
+        with:
+          command: test
+          toolchain: stable
+          args: --release --no-default-features
+
   miri-test:
     runs-on: ${{ matrix.os }}
     strategy:
-      fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
 
@@ -92,7 +136,7 @@ jobs:
           RUSTFLAGS: "-Zrandomize-layout"
           MIRIFLAGS: "-Zmiri-symbolic-alignment-check -Zmiri-check-number-validity -Zmiri-tag-raw-pointers -Zmiri-disable-isolation"
         run: |
-          cargo miri test --no-fail-fast --all-targets
+          cargo miri test --no-fail-fast --all-targets --no-default-features
 
   python-test:
     runs-on: ${{ matrix.os }}

.github/workflows/test.yaml

@@ -78,48 +78,23 @@ jobs:
           toolchain: stable
           args: --release
 
-  miri-test:
-    runs-on: ${{ matrix.os }}
-    needs: rust-test
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v1
-
-      - name: Get latest rust nightly version that has miri
-        id: versions
-        run: |
-          echo "::set-output name=rustc::nightly-$(curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/miri)"
-
-      - name: Cache Rust dependencies
-        uses: actions/cache@v2
-        with:
-          path: |
-            target
-            .cargo_home
-            .cargo
-          key: ${{ runner.os }}-no_pybindings-miri-${{ steps.versions.outputs.rustc }}-${{ hashFiles('Cargo.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-no_pybindings-miri-${{ steps.versions.outputs.rustc }}-
-
-      - name: Install rust ${{ steps.versions.outputs.rustc }}
-        uses: actions-rs/toolchain@v1
+      - name: Test in development mode (without default features)
+        uses: actions-rs/cargo@v1.0.1
+        env:
+          RUSTFLAGS: "-D warnings"
         with:
-          toolchain: ${{ steps.versions.outputs.rustc }}
-          profile: minimal
-          components: miri
-          override: true
+          command: test
+          toolchain: stable
+          args: --no-default-features
 
-      - name: Run tests in miri
+      - name: Test in release mode (without default features)
+        uses: actions-rs/cargo@v1.0.1
         env:
-          RUSTFLAGS: "-Zrandomize-layout"
-          MIRIFLAGS: "-Zmiri-symbolic-alignment-check -Zmiri-check-number-validity -Zmiri-tag-raw-pointers -Zmiri-disable-isolation"
-        run: |
-          cargo miri test --no-fail-fast --all-targets
+          RUSTFLAGS: "-D warnings"
+        with:
+          command: test
+          toolchain: stable
+          args: --release --no-default-features
 
   python-test:
     runs-on: ${{ matrix.os }}
@@ -184,7 +159,7 @@ jobs:
   testall:
     runs-on: ubuntu-latest
     name: Meta job for all tests
-    needs: [rust-test, miri-test, python-test]
+    needs: [rust-test, python-test]
     steps:
       - name: Done
         run: echo "All tests successful."

Cargo.toml

@@ -19,8 +19,16 @@ crate-type = ["rlib", "cdylib"]
 name = "constriction"
 
 [features]
-default = ["std"]
-std = ["probability"]
+default = ["std", "system_math"]
+
+# Features "system_math" is active by default. Deactivate it if your compilation
+# target has no system math C library (e.g., if you compile to WebAssembly).
+system_math = ["probability/system_math", "special/system_math"]
+
+# Feature "std" is active by default. Deactivate it if you want to compile
+# to a `no_std` target (e.g., a microcontroller). You'll likely want to
+# deactivate feature "system_math" as well in this case.
+std = ["probability/std", "special/std"]
 
 # Use feature `pybindings` to compile the python extension module that provides
 # access to this library from python. This feature is turned off by default
@@ -33,7 +41,10 @@ hashbrown = "0.11"
 num = "0.4"
 smallvec = "1.6.1"
 
-probability = {version = "0.17", optional = true}
+# special = {path = "../special", default-features = false}# Only used if "std" is deactivated.
+special = {git = "https://github.com/robamler/special.git", rev = "16708ea249ec56fbebfcc91b413142f01671ebd9", default-features = false}
+# probability = {path = "../probability", default-features = false}
+probability = {git = "https://github.com/robamler/probability.git", rev = "29c68c470990a9e5dbd13f8687f6bbe7edd61c00", default-features = false}
 
 ndarray = {version = "0.15", optional = true}
 numpy = {version = "0.15", optional = true}

benches/lookup.rs

@@ -23,10 +23,7 @@ criterion_group!(
     round_trip_u16_u32_u16_12
 );
 
-#[cfg(not(miri))]
 criterion::criterion_main!(benches);
-#[cfg(miri)]
-fn main() {} // All benchmarks currently use FFI and therefore can't be tested in miri.
 
 fn round_trip_u32_u64_u16_12(c: &mut Criterion) {
     round_trip::<u32, u64, u16, 12>(c);