Skip to content

Commit

Permalink
[llvm-readobj][NFC] Don't use startLine in a middle of a line in ObjD…
Browse files Browse the repository at this point in the history
…umper. (llvm#102071)
  • Loading branch information
cjacek authored and banach-space committed Aug 7, 2024
1 parent db8f399 commit 369624a
Showing 1 changed file with 16 additions and 14 deletions.
30 changes: 16 additions & 14 deletions llvm/tools/llvm-readobj/ObjDumper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,16 @@ void ObjDumper::printAsStringList(StringRef StringContent,
continue;
}
W.startLine() << format("[%6tx] ", CurrentWord - StrContent);
printAsPrintable(W.startLine(), CurrentWord, WordSize);
W.startLine() << '\n';
printAsPrintable(W.getOStream(), CurrentWord, WordSize);
W.getOStream() << '\n';
CurrentWord += WordSize + 1;
}
}

void ObjDumper::printFileSummary(StringRef FileStr, object::ObjectFile &Obj,
ArrayRef<std::string> InputFilenames,
const object::Archive *A) {
W.startLine() << "\n";
W.getOStream() << "\n";
W.printString("File", FileStr);
W.printString("Format", Obj.getFileFormatName());
W.printString("Arch", Triple::getArchTypeName(Obj.getArch()));
Expand Down Expand Up @@ -163,7 +163,8 @@ void ObjDumper::printSectionsAsString(const object::ObjectFile &Obj,
for (object::SectionRef Section :
getSectionRefsByNameOrIndex(Obj, Sections)) {
StringRef SectionName = unwrapOrError(Obj.getFileName(), Section.getName());
W.startLine() << "\nString dump of section '" << SectionName << "':\n";
W.getOStream() << '\n';
W.startLine() << "String dump of section '" << SectionName << "':\n";

StringRef SectionContent =
unwrapOrError(Obj.getFileName(), Section.getContents());
Expand All @@ -180,7 +181,8 @@ void ObjDumper::printSectionsAsHex(const object::ObjectFile &Obj,
for (object::SectionRef Section :
getSectionRefsByNameOrIndex(Obj, Sections)) {
StringRef SectionName = unwrapOrError(Obj.getFileName(), Section.getName());
W.startLine() << "\nHex dump of section '" << SectionName << "':\n";
W.getOStream() << '\n';
W.startLine() << "Hex dump of section '" << SectionName << "':\n";

StringRef SectionContent =
unwrapOrError(Obj.getFileName(), Section.getContents());
Expand All @@ -196,13 +198,13 @@ void ObjDumper::printSectionsAsHex(const object::ObjectFile &Obj,

W.startLine() << format_hex(Section.getAddress() + (SecPtr - SecContent),
10);
W.startLine() << ' ';
W.getOStream() << ' ';
for (i = 0; TmpSecPtr < SecEnd && i < 4; ++i) {
for (k = 0; TmpSecPtr < SecEnd && k < 4; k++, TmpSecPtr++) {
uint8_t Val = *(reinterpret_cast<const uint8_t *>(TmpSecPtr));
W.startLine() << format_hex_no_prefix(Val, 2);
W.getOStream() << format_hex_no_prefix(Val, 2);
}
W.startLine() << ' ';
W.getOStream() << ' ';
}

// We need to print the correct amount of spaces to match the format.
Expand All @@ -211,17 +213,17 @@ void ObjDumper::printSectionsAsHex(const object::ObjectFile &Obj,
// Least, if we cut in a middle of a row, we add the remaining characters,
// which is (8 - (k * 2)).
if (i < 4)
W.startLine() << format("%*c", (4 - i) * 8 + (4 - i), ' ');
W.getOStream() << format("%*c", (4 - i) * 8 + (4 - i), ' ');
if (k < 4)
W.startLine() << format("%*c", 8 - k * 2, ' ');
W.getOStream() << format("%*c", 8 - k * 2, ' ');

TmpSecPtr = SecPtr;
for (i = 0; TmpSecPtr + i < SecEnd && i < 16; ++i)
W.startLine() << (isPrint(TmpSecPtr[i])
? static_cast<char>(TmpSecPtr[i])
: '.');
W.getOStream() << (isPrint(TmpSecPtr[i])
? static_cast<char>(TmpSecPtr[i])
: '.');

W.startLine() << '\n';
W.getOStream() << '\n';
}
}
}
Expand Down

0 comments on commit 369624a

Please sign in to comment.