Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple platforms to use docker image #27

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

386jp
Copy link
Contributor

@386jp 386jp commented Nov 28, 2023

This PR sets a platform variable in GitHub Action config for Docker image deployment.
This allows people to use Docker image in arm-based system (like Asahi Linux), in addition to the amd-based system.

@banban525
Copy link
Owner

Thank you for your PR.
However, I'm not familiar with the "platforms" option.
I'll merge it after a little research.

@banban525
Copy link
Owner

@386jp

I understand the purpose of PR.
When doing Docker pull in an Arm environment, an error occurs because arm64 is not specified.

However, reading some blogs, it seems that "docker/setup-qemu-action" is required for GitHub action to use "platforms".
The current GitHub Action script does not have "docker/setup-qemu-action", which may cause the build to fail.

@banban525
Copy link
Owner

@386jp

However, your suggestion to create a container image for arm64 is great.
I'll merge this PR and debug it myself.

@banban525 banban525 merged commit 4ef2e2f into banban525:master Dec 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants