Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drivers adapters kotlin code 2 #189

Merged
merged 13 commits into from
Nov 25, 2021
Merged

Drivers adapters kotlin code 2 #189

merged 13 commits into from
Nov 25, 2021

Conversation

ElvertMora
Copy link
Contributor

@ElvertMora ElvertMora commented Nov 23, 2021 •
edited by dericop
Loading

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Add templates of drivers adapter for kotlin

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

@ElvertMora ElvertMora added Kotlin Support Projects Improvement Improve already existing code labels Nov 23, 2021
@ElvertMora ElvertMora self-assigned this Nov 23, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dericop
dericop approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@dericop dericop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but the next PR's must be smaller to facilitate review. For example each driven adapter as a PR (No more than 200 lines of code)

@dericop dericop merged commit 360f111 into master Nov 25, 2021
@dericop dericop deleted the drivers-adapters-kotlin-code-2 branch November 25, 2021 22:53
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dericop dericop dericop approved these changes

@santitigaga santitigaga Awaiting requested review from santitigaga

@jakspok jakspok Awaiting requested review from jakspok

@JuanDGiraldoM JuanDGiraldoM Awaiting requested review from JuanDGiraldoM

Assignees

@ElvertMora ElvertMora

Labels
Improvement Improve already existing code Kotlin Support Projects released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElvertMora @dericop