Task to update plugin and dependencies #193
Conversation
| public static List<String> getAllFilesWithExtension(boolean isKotlin) throws IOException { | ||
| String extension = isKotlin ? "gradle.kts" : "gradle"; | ||
| List<String> paths; | ||
| try (Stream<Path> walk = Files.walk(Paths.get("."))) { |
There was a problem hiding this comment.
Could you explain us why you are looking for the extensions?
There was a problem hiding this comment.
@jakspok that is because in tests this function walk in all directories, and found files that are not found in the project folder, if you have another solution i am open to change that.
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -66,7 +72,18 @@ public ModuleBuilder(Project project) { | |||
| } | |||
|
|
|||
| public void persist() throws IOException { | |||
| Release latestRelease = restService.getLatestPluginVersion(); | |||
| if (latestRelease != null) { | |||
There was a problem hiding this comment.
if (latestRelease != null && !latestRelease.getTagName().equals(Utils.getVersionPlugin()))
in a if the evaluation is left to right
| logger.lifecycle("Updating dependencies"); | ||
| List<String> gradleFiles = Utils.getAllFilesWithExtension(builder.isKotlin()); | ||
|
|
||
| if (dependencies.isEmpty()) { |
There was a problem hiding this comment.
I believe that this 'if' can be removed because if the collections is empty don't do noting. the only inconvenient in when the collection is null, i don know if this case occur
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing
Description
In this pull request append the task to update the dependency plugin and another dependencies
Category
Checklist