Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and clean plugin #194

Merged
merged 8 commits into from
Mar 15, 2022
Merged

Refactor and clean plugin #194

merged 8 commits into from
Mar 15, 2022

Conversation

jakspok
Copy link
Contributor

@jakspok jakspok commented Dec 6, 2021

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Category

  • Feature
  • [ X] Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.2% 86.2% Coverage
0.0% 0.0% Duplication

ElvertMora and others added 2 commits February 7, 2022 15:39
# Conflicts:
#	src/functionalTest/java/co/com/bancolombia/PluginCleanFunctionalTest.java
Rename Class
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.2% 86.2% Coverage
0.0% 0.0% Duplication

@dericop
Copy link
Contributor

dericop commented Mar 15, 2022

Please resolve the branch conflicts for merge!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.2% 86.2% Coverage
0.0% 0.0% Duplication

@jakspok jakspok merged commit 194aebf into master Mar 15, 2022
@jakspok jakspok deleted the refactor_and_clean branch March 15, 2022 20:11
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improve already existing code released work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants