Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the right title for kotlin structure picture #196

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Change the right title for kotlin structure picture #196

merged 1 commit into from
Jan 3, 2022

Conversation

XYF001
Copy link
Contributor

@XYF001 XYF001 commented Dec 15, 2021

Using kotlin for kotlin structure picture

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Change the right title for kotlin structure picture

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

Using kotlin for kotlin structure picture
@santitigaga santitigaga added the documentation Improvements or additions to documentation label Dec 23, 2021
@XYF001 XYF001 closed this Dec 25, 2021
@XYF001 XYF001 reopened this Dec 25, 2021
@XYF001 XYF001 requested a review from santitigaga December 25, 2021 03:34
@XYF001
Copy link
Contributor Author

XYF001 commented Dec 25, 2021

Hi @santitigaga , need help to review again , as I close and reopen the pr, to re run the build task. Thanks.

@XYF001
Copy link
Contributor Author

XYF001 commented Dec 25, 2021

build failed. Seems Deprecated Gradle features were used .

`> Task :functionalTest

co.com.bancolombia.PluginCleanFunctionalTest > shouldUpdateProjectWithOneDependency FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at PluginCleanFunctionalTest.java:966

co.com.bancolombia.PluginCleanFunctionalTest > shouldUpdateProject FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at PluginCleanFunctionalTest.java:954

36 tests completed, 2 failed

Task :functionalTest FAILED
Task :compileTestJava UP-TO-DATE
Task :processTestResources
Task :testClasses
Task :test UP-TO-DATE
Task :validatePlugins
Task :verifyGoogleJavaFormat

FAILURE: Build failed with an exception.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.`

@santitigaga santitigaga merged commit ff963ec into bancolombia:master Jan 3, 2022
@XYF001 XYF001 deleted the XYF001-FIX-TYPO branch January 4, 2022 11:59
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants