Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feacture added to generate SQS reactive delivery adapter for the kotlin language #273

Merged

Conversation

AlexixsGit
Copy link

@AlexixsGit AlexixsGit commented Jun 26, 2022

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

This feature allows to add a SQS reactive driven adapter for the kotlin language.
This commit fixes issue #255

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide

…n.json for sqs reactive kotlin driven adapter
This commit has the required classes to generate a SQS reactive delivery adapter for the kotlin language
This commit has the required classes to generate a SQS reactive delivery adapter for the kotlin language
@jakspok jakspok added the enhancement New feature or request label Jun 29, 2022
@jakspok
Copy link
Contributor

jakspok commented Jun 29, 2022

Hello, how are you @AlexixsGit reviewing your contribution the canDeleteModule test is failing could you correct it to approve your contribution, in the same way the branch is presenting conflicts thanks

@santitigaga santitigaga linked an issue Jun 30, 2022 that may be closed by this pull request
@AlexixsGit
Copy link
Author

I resolved the conflict and with a merge with the master branch all test passed successfully.

Screen Shot 2022-06-30 at 8 51 23 PM

@jakspok
Copy link
Contributor

jakspok commented Jul 1, 2022

Hello, how are you AlexixsGit reviewing your contribution the observations mentioned above are verified.... thank you very much

Copy link
Contributor

@jakspok jakspok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you contribution

@jakspok jakspok merged commit e31d840 into bancolombia:master Jul 5, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add driven adapter SQS for Kotlin reactive
2 participants