fix unit tests #277
Merged
fix unit tests #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the help, When I execute the unit test in this branch with windows,5 tests fail |
davidpolaniaac
force-pushed
the
fix-unit-tests
branch
from
81d99d8 to
8ac343b
Compare
|
@santitigaga thanks for the review. There are two types of error, one is due to the management of routes according to the operating system and the conflicts of the IDEs files. Both are solved. 👍 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing
Description
Fix issue #245
Some IDEs like VSCode or Eclipse use the bin folder to compile and use resources. The plugin searches all the files by specific extension and concatenates it to the root of the test project, which generates an inconsistency in the file path, so the valid directories for file search are filtered.
Absolute paths in windows contain a disk letter is solved by validating the type of path.
Category
Checklist