Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use primitive boolean instead of Boolean class #285

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Use primitive boolean instead of Boolean class #285

merged 2 commits into from
Aug 9, 2022

Conversation

juancgalvis
Copy link
Contributor

Description

Fix this code smell
image

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide

@juancgalvis juancgalvis requested a review from santitigaga August 9, 2022 13:14
santitigaga
santitigaga approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juancgalvis juancgalvis merged commit e6b1c2d into master Aug 9, 2022
@juancgalvis juancgalvis deleted the feature/primitive-boolean-issue branch August 9, 2022 15:24
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santitigaga santitigaga santitigaga approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juancgalvis @santitigaga