Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance test #302

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Performance test #302

merged 2 commits into from
Jan 19, 2023

Conversation

maocq
Copy link
Contributor

@maocq maocq commented Jan 18, 2023

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide

@santitigaga
Copy link
Contributor

@maocq please add abstract in the PR

@santitigaga santitigaga self-requested a review January 19, 2023 15:17
@santitigaga
Copy link
Contributor

src/main/resources/test/performance-test/jmeter/Jmeter/Api/DataSet/DT_Ejemplo.csv.mustache
src/main/resources/test/performance-test/jmeter/Jmeter/Api/DataSet/DT_Ejemplo.txt.mustache
why this files are empty?

@santitigaga
Copy link
Contributor

please add functional tests

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

79.4% 79.4% Coverage
0.0% 0.0% Duplication

@maocq maocq merged commit 06689aa into master Jan 19, 2023
@maocq maocq deleted the feature/performance-test branch January 19, 2023 16:25
@santitigaga
Copy link
Contributor

santitigaga commented Jan 19, 2023

you need to add this instruction in the task sendAnalytics(name, System.currentTimeMillis() - start);

@maocq maocq mentioned this pull request Jan 19, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants