Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/automatic factory type detection #359

Merged
merged 13 commits into from
May 29, 2023
Merged

Feature/automatic factory type detection #359

merged 13 commits into from
May 29, 2023

Conversation

juancgalvis
Copy link
Contributor

@juancgalvis juancgalvis commented May 26, 2023 •
edited
Loading

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Features:

  • Remove duplicated code of tasks
  • Create the new CATAsk annotation to set task metadata and enable automatic task discovery
  • Enable ModuleFactory discovery by class prefix (DrivenAdapter, EntryPoint, etc...) and automatic module type by class example name: DrivenAdapterMongoDB -> type: MONGODB.
  • Update Java 11 with Gradle 8.1.1

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

@juancgalvis juancgalvis requested review from santitigaga, maocq and gabheadz and removed request for maocq May 26, 2023 21:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

87.6% 87.6% Coverage
0.0% 0.0% Duplication

@juancgalvis juancgalvis merged commit 8447f70 into master May 29, 2023
@juancgalvis juancgalvis deleted the feature/automatic-factory-type-detection branch May 29, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santitigaga santitigaga santitigaga approved these changes

@gabheadz gabheadz Awaiting requested review from gabheadz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juancgalvis @santitigaga