Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/eda #383

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Feature/eda #383

merged 4 commits into from
Aug 1, 2023

Conversation

juancgalvis
Copy link
Contributor

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Add EDA variant of Reactive Commons

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

juancgalvis and others added 4 commits July 24, 2023 08:28
@juancgalvis
Add eda variant support
bb3494b
@jespinosas
Feature/eda (#382)
838173c 
* Cambios en version de asyncevents

* modificacion de ejemplo

* Cambios a ejemplos

* Cambios a ejemplos

* Cambios a ejemplos

* modificacion entry point

---------

Co-authored-by: Jorge Espinosa <joeespin@bancolombia.com.co>
@juancgalvis
format
dd1866e
@juancgalvis
format
10d049f
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

santitigaga
santitigaga approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@juancgalvis juancgalvis merged commit 656e8ff into master Aug 1, 2023
@juancgalvis juancgalvis deleted the feature/eda branch August 1, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santitigaga santitigaga santitigaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancgalvis @santitigaga @jespinosas