Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorization with jwt token in entrypoint restmvc #402

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

braduran
Copy link
Contributor

@braduran braduran commented Nov 8, 2023

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Add authorization with jwt tokens for #350 issue.
This could work with multiple identity management providers. Local tests were made with Azure AD and Keycloak.
Please don't close the issue, I would like to implement this feature to webflux.

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

Copy link
Contributor

@juancgalvis juancgalvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @braduran

@juancgalvis juancgalvis merged commit feda805 into bancolombia:master Nov 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants