Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sonar properties #412

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix Sonar properties #412

merged 2 commits into from
Dec 15, 2023

Conversation

JorgeA1206
Copy link
Contributor

@JorgeA1206 JorgeA1206 commented Dec 15, 2023 •
edited
Loading

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Fix sourceEncoding property for sonarqube task and set jacocoMergedReport path to xmlReportPaths property on build.gradle root file

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

@JorgeA1206 JorgeA1206 changed the title Fix Sonar property Fix Sonar properties Dec 15, 2023
santitigaga
santitigaga approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!! thanks for the help 👍

@santitigaga santitigaga merged commit 855477b into bancolombia:master Dec 15, 2023
6 checks passed
@juancgalvis
Copy link
Contributor

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santitigaga santitigaga santitigaga approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorgeA1206 @juancgalvis @santitigaga