Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(unit): Update unit tests to improve maintainability #431

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

juancgalvis
Copy link
Contributor

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing

Description

Upgrade unit tests to improve project maintainability, closes #420

Category

  • Feature
  • Fix
  • Ci / Docs

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has a new driven-adpater or entry-point, you should add it to RADME.md and sh_generate_project.sh files for generated code tests.
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

66.7% Coverage on New Code (required ≥ 70.0%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@juancgalvis juancgalvis merged commit 2c040b9 into master Jan 23, 2024
8 checks passed
@juancgalvis juancgalvis deleted the feature/improve-tests branch January 23, 2024 19:05
@juancgalvis
Copy link
Contributor Author

🎉 This PR is included in version 3.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve maintainability on unit tests
2 participants