Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/change secrets impl #45

Merged
merged 10 commits into from
Apr 28, 2020

Conversation

juanes1a
Copy link
Contributor

#44 The implementation of secrets was changed because it should not be a driven adapter, it was refactored to be part of a @bean and the secrets will be available at the beginning of the application.

Also i add the JPAConfig configuration file and the Yaml properties file attached to the application-properties. this files are generated only when is created the Jpa Repository Driven Adapter

@santitigaga santitigaga self-requested a review April 28, 2020 14:07
@santitigaga santitigaga added the enhancement New feature or request label Apr 28, 2020
@santitigaga santitigaga linked an issue Apr 28, 2020 that may be closed by this pull request
Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobado

@santitigaga santitigaga merged commit 06d7d84 into bancolombia:master Apr 28, 2020
@juanes1a juanes1a deleted the feature/changeSecretsImpl branch April 28, 2020 14:39
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change secrets manager implementation
2 participants