Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): fix UpgradeAction for gradle 8.11 #586

Merged

Conversation

luisgomez29
Copy link
Contributor

Add validation in Gradle 8.11 upgrade action to avoid duplicating java {} block in main.gradle file #585

Category

  • Feature
  • Fix
  • Ci / Docs

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has a new driven-adapter or entry-point, you should add it to docs and sh_generate_project.sh files for generated code tests.
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

@luisgomez29 luisgomez29 changed the title feat(gradle): fix UpgradeAction for gradle 8.11 fix(gradle): fix UpgradeAction for gradle 8.11 Nov 20, 2024
@santitigaga
Copy link
Contributor

@luisgomez29 you are faster, thank you for the help, could you add new test to validate that, maiby compare main.gradle.after After updating and giving the same result ?

Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another test

@luisgomez29
Copy link
Contributor Author

Hi @santitigaga, add test to verify that the update should not be applied if java block exists

Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🔥

@santitigaga santitigaga merged commit 0f5073d into bancolombia:master Nov 20, 2024
6 checks passed
Copy link
Contributor

🎉 This PR is included in version 3.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants