Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

trigger transactions - identify a "speed up" transaction #766

Closed
ashachaf opened this issue Dec 22, 2020 · 4 comments
Closed

trigger transactions - identify a "speed up" transaction #766

ashachaf opened this issue Dec 22, 2020 · 4 comments
Assignees
Labels
Blockchain logic bug Something isn't working

Comments

@ashachaf
Copy link
Collaborator

as a user, i can decide to speed up the transaction in order to have it executed faster.
this result in creating a new transaction with new hash on the blockchain.
however, our application doesnt know to track the new transaction and. is kept stuck pending waiting for the dropped transaction to complete.

image

reproduce:

  1. click swap tkn->bnt
  2. set the gas cost of the approve to very low
  3. speed up the transaction using metamask
@ashachaf ashachaf added Blockchain logic bug Something isn't working labels Dec 22, 2020
@Velua
Copy link
Contributor

Velua commented Jan 27, 2021

@Ran73Cohen See if you can detect the change that @ashachaf creates when he speeds up a transaction, might be able to listen to it as we are with the .on(" use in the resolveTxOnConfirmation method in ethBancor.ts

@Velua Velua assigned Velua and unassigned RanCohenn Apr 6, 2021
@Velua
Copy link
Contributor

Velua commented Apr 6, 2021

I'll see if I can find of anything but as of now our understanding is that Web3 won't allow us to follow the transaction once it's been sped up, resulting in us losing track of it and not being able to handle it the way we'd like too.

@ashachaf
Copy link
Collaborator Author

ashachaf commented Apr 6, 2021

web3/web3.js#3585

@Velua
Copy link
Contributor

Velua commented Apr 22, 2021

Looks like this is still yet to be officially supported at web3/web3.js#3723 (comment)

But I've found a tweet which might serve as a nice work around, someone has also made a commit in another project which should serve as a good example. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Blockchain logic bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants