Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simulation test for Oracle module #318

Merged
merged 17 commits into from
Feb 22, 2024
Merged

Add simulation test for Oracle module #318

merged 17 commits into from
Feb 22, 2024

Conversation

RogerKSI
Copy link
Contributor

@RogerKSI RogerKSI commented Aug 12, 2023 •
edited
Loading

Implementation details

  • Add simulation test for oracle module
  • Adjust testing structure to separate testdata and testapp (prevent cycle import)
  • Add Github action for running simualtion test

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI marked this pull request as draft August 12, 2023 10:01
@RogerKSI RogerKSI marked this pull request as ready for review August 12, 2023 11:53
@RogerKSI RogerKSI force-pushed the add-simulation-oracle branch from b209baa to 5e49c03 Compare August 22, 2023 15:53
@colmazia
Copy link
Contributor

colmazia commented Sep 1, 2023

Interesting, would be great to see some demos

@RogerKSI RogerKSI force-pushed the add-simulation-oracle branch from 2598315 to 9dd262e Compare September 1, 2023 09:47
colmazia
colmazia reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@colmazia colmazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit a review

Makefile Outdated Show resolved Hide resolved
x/oracle/simulation/operations.go Show resolved Hide resolved
x/oracle/simulation/operations_test.go Show resolved Hide resolved
@RogerKSI RogerKSI requested a review from colmazia September 4, 2023 04:05
Base automatically changed from cosmos-sdk-v0.47 to master October 6, 2023 08:04
taobun
taobun reviewed Nov 30, 2023
View reviewed changes
x/oracle/abci.go Show resolved Hide resolved
x/oracle/simulation/genesis.go Outdated Show resolved Hide resolved
@RogerKSI RogerKSI requested a review from taobun February 11, 2024 15:03
taobun
taobun requested changes Feb 21, 2024
View reviewed changes
x/oracle/abci.go Outdated Show resolved Hide resolved
RogerKSI
RogerKSI commented Feb 21, 2024
View reviewed changes
x/oracle/abci.go Outdated Show resolved Hide resolved
@RogerKSI RogerKSI requested a review from taobun February 21, 2024 09:25
@taobun taobun merged commit 23d302b into master Feb 22, 2024
7 checks passed
@taobun taobun deleted the add-simulation-oracle branch February 22, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmazia colmazia colmazia approved these changes

@satawatnack satawatnack satawatnack approved these changes

@taobun taobun taobun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RogerKSI @colmazia @taobun @satawatnack