Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init refactor testapp #330

Merged
merged 13 commits into from
May 2, 2024
Merged

init refactor testapp #330

merged 13 commits into from
May 2, 2024

Conversation

satawatnack
Copy link
Member

@satawatnack satawatnack commented Sep 19, 2023 •
edited
Loading

Implementation details

  • refactor tesapp with more structure and change file name to the standard cosmos chain test_helpers.go

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@satawatnack satawatnack requested review from RogerKSI and colmazia and removed request for RogerKSI September 19, 2023 06:59
@colmazia colmazia requested a review from RogerKSI September 20, 2023 04:57
colmazia
colmazia reviewed Sep 20, 2023
View reviewed changes
testing/test_helpers.go Outdated Show resolved Hide resolved
@RogerKSI RogerKSI requested a review from taobun September 20, 2023 08:42
RogerKSI
RogerKSI reviewed Sep 20, 2023
View reviewed changes
benchmark/helper_test.go Outdated Show resolved Hide resolved
@RogerKSI
Copy link
Contributor

please help check conflict.

@RogerKSI
Copy link
Contributor

@satawatnack Can add more detail on PR? like what changed? idea?

Base automatically changed from cosmos-sdk-v0.47 to master October 6, 2023 08:04
@RogerKSI RogerKSI self-requested a review February 13, 2024 17:34
@RogerKSI RogerKSI requested a review from nkitlabs May 2, 2024 08:48
colmazia
colmazia reviewed May 2, 2024
View reviewed changes
testing/test_helpers.go Outdated Show resolved Hide resolved
@RogerKSI RogerKSI requested a review from colmazia May 2, 2024 10:54
@RogerKSI RogerKSI merged commit d46e1d9 into master May 2, 2024
2 checks passed
@RogerKSI RogerKSI deleted the v0.47-refactor-testdata branch May 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerKSI RogerKSI RogerKSI approved these changes

@colmazia colmazia colmazia approved these changes

@taobun taobun taobun approved these changes

@nkitlabs nkitlabs Awaiting requested review from nkitlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satawatnack @RogerKSI @taobun @colmazia