Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extra/rest] Add sender account in case use bank keeper to send coins #524

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

satawatnack
Copy link
Member

@satawatnack satawatnack commented Dec 16, 2024

Implementation details

  • add sender account in case use bank keeper to send coins

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@satawatnack satawatnack changed the title add sender account in case use bank keeper to send coins [Extra/rest] add sender account in case use bank keeper to send coins Dec 16, 2024
@satawatnack satawatnack changed the title [Extra/rest] add sender account in case use bank keeper to send coins [Extra/rest] Add sender account in case use bank keeper to send coins Dec 16, 2024
@RogerKSI RogerKSI requested a review from colmazia December 17, 2024 09:40
@RogerKSI RogerKSI merged commit 828d9c3 into extra/rest Dec 17, 2024
2 checks passed
@RogerKSI RogerKSI deleted the extra/rest-handle-send-coins branch December 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants