Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AWS provider #120

Merged
merged 7 commits into from
May 14, 2024
Merged

feat: AWS provider #120

merged 7 commits into from
May 14, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Apr 8, 2024 •
edited

Overview

@csatib02
feat: AWS provider
32fe36e 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 added kind/enhancement Categorizes issue or PR as related to an improvement. area/provider/aws kind/feature Categorizes issue or PR as related to a new feature. labels Apr 8, 2024
@csatib02 csatib02 self-assigned this Apr 8, 2024
@csatib02 csatib02 requested a review from a team as a code owner April 8, 2024 12:26
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Apr 8, 2024
@csatib02 csatib02 removed the request for review from a team April 8, 2024 12:27
@csatib02
fix: remove unnecessary map usage after secret loading
52f52b3 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
chore: minor fixes
6b4006b 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
chore: Remove version from docker-compose since its obsolete
f8a3b43 
Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
ramizpolic requested changes May 13, 2024
View reviewed changes
pkg/provider/aws/config.go Outdated Show resolved Hide resolved
env_store.go Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
@csatib02
fix: remarks
3b90615 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 requested a review from ramizpolic May 13, 2024 15:20
ramizpolic
ramizpolic requested changes May 13, 2024
View reviewed changes
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/config.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
@csatib02
refactor: remove usage of emperror.dev/errors package
3cf9c95 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix: unify secret handling in case of AWS SM
32842d7 
Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
ramizpolic approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done @csatib02!

@csatib02 csatib02 merged commit 1c577f3 into main May 14, 2024
20 checks passed
@csatib02 csatib02 deleted the feat/add-aws-provider branch May 25, 2024 12:37
@csatib02 csatib02 mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@csatib02 csatib02

Labels
area/provider/aws kind/enhancement Categorizes issue or PR as related to an improvement. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 500-999 lines
Projects
Project backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Secret Management integration
2 participants
@csatib02 @ramizpolic