Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GCP provider #143

Merged
merged 6 commits into from
May 23, 2024
Merged

feat: GCP provider #143

merged 6 commits into from
May 23, 2024

Conversation

csatib02
Copy link
Member

Overview

  • Added support for GCP Secret Manager.

@csatib02
feat: add gcp secret manager provider
e041989 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 added area/provider/gcp kind/feature Categorizes issue or PR as related to a new feature. labels May 22, 2024
@csatib02 csatib02 self-assigned this May 22, 2024
@csatib02 csatib02 requested a review from a team as a code owner May 22, 2024 11:59
@csatib02 csatib02 removed the request for review from a team May 22, 2024 11:59
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label May 22, 2024
@csatib02
docs: add gcp, update other docs
96ed4a0 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
chore: update nix
6ecdebf 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@github-actions github-actions bot added size/L Denotes a PR that changes 500-999 lines and removed size/M Denotes a PR that changes 100-499 lines labels May 22, 2024
sagikazarmark
sagikazarmark approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pkg/provider/bao/bao.go Show resolved Hide resolved
pkg/provider/gcp/gcp.go Outdated Show resolved Hide resolved
@csatib02
fix(gcp): Remarks
7da5416 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix(test): get env path for args test
11d485b 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix(README): Add AWS SSM to supported providers
4edba8f 
Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
ramizpolic approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate it @csatib02!

@csatib02 csatib02 merged commit 9d3ccc9 into main May 23, 2024
20 checks passed
@csatib02 csatib02 deleted the feat/gcp-provider branch May 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

@ramizpolic ramizpolic ramizpolic approved these changes

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@csatib02 csatib02

Labels
area/provider/gcp kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 500-999 lines
Projects
Project backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@csatib02 @sagikazarmark @ramizpolic