-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider selection logic, file provider and tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
requested changes
Nov 14, 2023
akijakya
requested changes
Nov 14, 2023
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
reviewed
Nov 20, 2023
ramizpolic
reviewed
Nov 20, 2023
ramizpolic
reviewed
Nov 20, 2023
ramizpolic
reviewed
Nov 20, 2023
ramizpolic
reviewed
Nov 20, 2023
ramizpolic
reviewed
Nov 20, 2023
ramizpolic
reviewed
Nov 20, 2023
…ogic to provider package, and minor fixes Signed-off-by: Bence Csati <csatib02@gmail.com>
…o provider package Signed-off-by: Bence Csati <csatib02@gmail.com>
…ed tests Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the final review on the overall logic. The flow makes sense now 👍
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @csatib02, lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR contains a file provider, with tests, and implemented provider selection logic.
Continuation of issue: #1
Functionality
The provider selection works by getting it from an environment variable.
The file provider by default uses
/
as root path for file system.The
main
function has been reworked:env.go
has been created.It encapsulates functionality extracted from the
main
package, providing a clean separation of concerns and promoting reusability. This approach also enhances testability.