Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add e2e tests #51

Merged
merged 9 commits into from
Feb 1, 2024
Merged

feat: Add e2e tests #51

merged 9 commits into from
Feb 1, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Jan 25, 2024 •
edited

Overview

  • Add e2e tests using bats-core framework.
  • Improved the makefile similar to those in other Bank-Vaults repo.
  • The tests are connected to the CI.

@csatib02
feat(e2e): add e2e tests, improve makefile
69164f2 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02 csatib02 self-assigned this Jan 25, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Jan 25, 2024
@csatib02
chore: minor fixes
951aaae 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(ci): go cache
39cd12d 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
feat(e2e): add test for daemon mode
5db2e9f 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02 csatib02 marked this pull request as ready for review January 26, 2024 12:11
ramizpolic
ramizpolic reviewed Jan 30, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
ramizpolic
ramizpolic reviewed Jan 30, 2024
View reviewed changes
Makefile Show resolved Hide resolved
e2e/file.bats Outdated Show resolved Hide resolved
@csatib02
fix(makefile): add bats dependency
fd81280 
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
ramizpolic requested changes Jan 30, 2024
View reviewed changes
e2e/vault-provider.bats Outdated Show resolved Hide resolved
e2e/file-provider.bats Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@csatib02
fix(makefile): add bats dependency, fix goreleaser dep
28fc14c 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(makefile): fix bats dependency
175750b 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(makefile): minor fix
d0fafe0 
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
ramizpolic requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the suggested changes, everything works properly, both the make targets and the bats tests

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
e2e/vault-provider.bats Outdated Show resolved Hide resolved
e2e/vault-provider.bats Outdated Show resolved Hide resolved
e2e/vault-provider.bats Outdated Show resolved Hide resolved
@csatib02
fix(makefile): minor fixes
9da6be8 
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
ramizpolic approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly, good job :shipit:

@ramizpolic ramizpolic merged commit 9b36635 into bank-vaults:main Feb 1, 2024
20 checks passed
@csatib02 csatib02 deleted the feat/e2e branch February 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees

@csatib02 csatib02

Labels
size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csatib02 @ramizpolic