-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement multi provider support #59
Merged
ramizpolic
merged 7 commits into
bank-vaults:main
from
csatib02:feat/multi-provider-support
Feb 9, 2024
Merged
feat: Implement multi provider support #59
ramizpolic
merged 7 commits into
bank-vaults:main
from
csatib02:feat/multi-provider-support
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tests Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
requested changes
Feb 9, 2024
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
reviewed
Feb 9, 2024
Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done @csatib02, looks great!
csatib02
added a commit
to csatib02/secret-init
that referenced
this pull request
Feb 15, 2024
* feat(multi-provider support): Implement multi-provider support, adjust tests Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(e2e): Adjust e2e tests Signed-off-by: Bence Csati <csatib02@gmail.com> * chore(README): e2e Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(e2e): put back single-provider tests Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(env_store.go): fix remarks Signed-off-by: Bence Csati <csatib02@gmail.com> * chore: minor fixes Signed-off-by: Bence Csati <csatib02@gmail.com> * chore: naming Signed-off-by: Bence Csati <csatib02@gmail.com> --------- Signed-off-by: Bence Csati <csatib02@gmail.com> Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
added a commit
to csatib02/secret-init
that referenced
this pull request
Feb 15, 2024
This reverts commit e41283e.
csatib02
added a commit
to csatib02/secret-init
that referenced
this pull request
Feb 15, 2024
* feat(multi-provider support): Implement multi-provider support, adjust tests Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(e2e): Adjust e2e tests Signed-off-by: Bence Csati <csatib02@gmail.com> * chore(README): e2e Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(e2e): put back single-provider tests Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(env_store.go): fix remarks Signed-off-by: Bence Csati <csatib02@gmail.com> * chore: minor fixes Signed-off-by: Bence Csati <csatib02@gmail.com> * chore: naming Signed-off-by: Bence Csati <csatib02@gmail.com> --------- Signed-off-by: Bence Csati <csatib02@gmail.com> Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
added a commit
to csatib02/secret-init
that referenced
this pull request
Feb 15, 2024
This reverts commit e41283e. Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
pushed a commit
that referenced
this pull request
Feb 15, 2024
* feat: Implement multi provider support (#59) * feat(multi-provider support): Implement multi-provider support, adjust tests Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(e2e): Adjust e2e tests Signed-off-by: Bence Csati <csatib02@gmail.com> * chore(README): e2e Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(e2e): put back single-provider tests Signed-off-by: Bence Csati <csatib02@gmail.com> * fix(env_store.go): fix remarks Signed-off-by: Bence Csati <csatib02@gmail.com> * chore: minor fixes Signed-off-by: Bence Csati <csatib02@gmail.com> * chore: naming Signed-off-by: Bence Csati <csatib02@gmail.com> --------- Signed-off-by: Bence Csati <csatib02@gmail.com> Signed-off-by: Bence Csati <bcsati@cisco.com> * feat(ci): cancel previous workflow on push Signed-off-by: Bence Csati <bcsati@cisco.com> * Revert "feat(ci): cancel previous workflow on push" This reverts commit 55e945f. Signed-off-by: Bence Csati <bcsati@cisco.com> * feat(ci): cancel previous workflow on push Signed-off-by: Bence Csati <bcsati@cisco.com> * Revert "feat: Implement multi provider support (#59)" This reverts commit e41283e. Signed-off-by: Bence Csati <bcsati@cisco.com> --------- Signed-off-by: Bence Csati <csatib02@gmail.com> Signed-off-by: Bence Csati <bcsati@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PROVIDER
environment variable has been eliminated.Fixes: #56