Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement multi provider support #59

Merged
merged 7 commits into from
Feb 9, 2024
Merged

feat: Implement multi provider support #59

merged 7 commits into from
Feb 9, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Feb 1, 2024 •
edited

Overview

  • This pull request introduces multi-provider support to secret-init.
  • The necessity of the PROVIDER environment variable has been eliminated.
  • Providers are now dynamically created based on environment variables that reference secrets.
  • The process of creating providers and loading them is now executed in distinct goroutines.

Fixes: #56

@csatib02
feat(multi-provider support): Implement multi-provider support, adjus…
1f00b93 
…t tests

Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(e2e): Adjust e2e tests
ffe6272 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02 csatib02 self-assigned this Feb 1, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Feb 1, 2024
@csatib02
chore(README): e2e
600062e 
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
ramizpolic requested changes Feb 9, 2024
View reviewed changes
e2e/file-provider.bats Show resolved Hide resolved
e2e/main-test.bats Outdated Show resolved Hide resolved
env_store.go Outdated Show resolved Hide resolved
env_store.go Outdated Show resolved Hide resolved
env_store.go Outdated Show resolved Hide resolved
env_store.go Outdated Show resolved Hide resolved
env_store.go Outdated Show resolved Hide resolved
env_store_test.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@csatib02
fix(e2e): put back single-provider tests
e5cceca 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(env_store.go): fix remarks
e20b838 
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
ramizpolic reviewed Feb 9, 2024
View reviewed changes
e2e/file-provider.bats Outdated Show resolved Hide resolved
env_store.go Outdated Show resolved Hide resolved
@csatib02
chore: minor fixes
3af2535 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
chore: naming
2a58a20 
Signed-off-by: Bence Csati <csatib02@gmail.com>
ramizpolic
ramizpolic approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done @csatib02, looks great! :shipit:

@ramizpolic ramizpolic merged commit 4029fc8 into bank-vaults:main Feb 9, 2024
20 checks passed
@csatib02 csatib02 deleted the feat/multi-provider-support branch February 9, 2024 18:35
csatib02 added a commit to csatib02/secret-init that referenced this pull request Feb 15, 2024
@csatib02
feat: Implement multi provider support (bank-vaults#59)
e41283e 
* feat(multi-provider support): Implement multi-provider support, adjust tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(e2e): Adjust e2e tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore(README): e2e

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(e2e): put back single-provider tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(env_store.go): fix remarks

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore: minor fixes

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore: naming

Signed-off-by: Bence Csati <csatib02@gmail.com>

---------

Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02 added a commit to csatib02/secret-init that referenced this pull request Feb 15, 2024
@csatib02
Revert "feat: Implement multi provider support (bank-vaults#59)"
a348812 
This reverts commit e41283e.
csatib02 added a commit to csatib02/secret-init that referenced this pull request Feb 15, 2024
@csatib02
feat: Implement multi provider support (bank-vaults#59)
c414d9e 
* feat(multi-provider support): Implement multi-provider support, adjust tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(e2e): Adjust e2e tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore(README): e2e

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(e2e): put back single-provider tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(env_store.go): fix remarks

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore: minor fixes

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore: naming

Signed-off-by: Bence Csati <csatib02@gmail.com>

---------

Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02 added a commit to csatib02/secret-init that referenced this pull request Feb 15, 2024
@csatib02
Revert "feat: Implement multi provider support (bank-vaults#59)"
e53c0c1 
This reverts commit e41283e.

Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic pushed a commit that referenced this pull request Feb 15, 2024
@csatib02
feat: Cancel previous workflow on push (#77)
586313f 
* feat:  Implement multi provider support (#59)

* feat(multi-provider support): Implement multi-provider support, adjust tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(e2e): Adjust e2e tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore(README): e2e

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(e2e): put back single-provider tests

Signed-off-by: Bence Csati <csatib02@gmail.com>

* fix(env_store.go): fix remarks

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore: minor fixes

Signed-off-by: Bence Csati <csatib02@gmail.com>

* chore: naming

Signed-off-by: Bence Csati <csatib02@gmail.com>

---------

Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>

* feat(ci): cancel previous workflow on push

Signed-off-by: Bence Csati <bcsati@cisco.com>

* Revert "feat(ci): cancel previous workflow on push"

This reverts commit 55e945f.

Signed-off-by: Bence Csati <bcsati@cisco.com>

* feat(ci): cancel previous workflow on push

Signed-off-by: Bence Csati <bcsati@cisco.com>

* Revert "feat:  Implement multi provider support (#59)"

This reverts commit e41283e.

Signed-off-by: Bence Csati <bcsati@cisco.com>

---------

Signed-off-by: Bence Csati <csatib02@gmail.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees

@csatib02 csatib02

Labels
size/L Denotes a PR that changes 500-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-provider support
2 participants
@csatib02 @ramizpolic