Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bao provider #92

Merged
merged 13 commits into from
Apr 8, 2024
Merged

feat: add bao provider #92

merged 13 commits into from
Apr 8, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Mar 1, 2024 •
edited

Overview

  • Added support for the openBao provider.
  • The provider can still use the Vault-sdk, so there has been no changes to the original Vault interface.
  • The provider not yet utilizes the BAO_ADDR in the client so a workaround has been applied in provider/bao/config.go and in env_store.go/workaroundForBao(), but that can be addressed when the first openBao release is out: Remove openBao workaround when its been released #112
  • Added both unit and e2e tests for the Bao provider.
  • Currently there is no nixPkg available for openBao, an issue can be opened in this case.
  • Ended up removing a not so important test because it started failing since gh actions v4.x.x.
  • I noticed that the e2e tests for daemon-mode were not quite useful... Made them so.

Fixes #89, #95

@csatib02 csatib02 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 1, 2024
@csatib02 csatib02 self-assigned this Mar 1, 2024
@csatib02 csatib02 requested a review from a team as a code owner March 1, 2024 12:15
@github-actions github-actions bot added the size/XL Denotes a PR that changes 1000+ lines label Mar 1, 2024
@csatib02 csatib02 removed the request for review from a team March 1, 2024 12:16
akijakya
akijakya approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csatib02 @akijakya
feat: add bao provider
30cdf05 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 @akijakya
feat: add bao provider to docs
bb3fd6b 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 @akijakya
feat: fully integrate openbao
dc76ffa 
Signed-off-by: Bence Csati <bcsati@cisco.com>

chore: bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3

Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.1 to 3.0.3.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md)
- [Commits](go-jose/go-jose@v3.0.1...v3.0.3)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump docker/build-push-action from 5.1.0 to 5.2.0

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@4a13e50...af5a7ed)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump docker/build-push-action from 5.2.0 to 5.3.0

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@af5a7ed...2cdde99)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump actions/checkout from 4.1.1 to 4.1.2

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@b4ffde6...9bb5618)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump golang from 1.22.0-alpine3.18 to 1.22.1-alpine3.18

Bumps golang from 1.22.0-alpine3.18 to 1.22.1-alpine3.18.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump aquasecurity/trivy-action from 0.17.0 to 0.18.0

Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.17.0 to 0.18.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@84384bd...062f259)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump github.com/stretchr/testify from 1.8.4 to 1.9.0

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump actions/cache from 4.0.0 to 4.0.1

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@13aacd8...ab5e6d0)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump cachix/install-nix-action from 25 to 26

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 25 to 26.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](cachix/install-nix-action@6004951...8887e59)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump DeterminateSystems/magic-nix-cache-action from 3 to 4

Bumps [DeterminateSystems/magic-nix-cache-action](https://github.com/determinatesystems/magic-nix-cache-action) from 3 to 4.
- [Release notes](https://github.com/determinatesystems/magic-nix-cache-action/releases)
- [Commits](DeterminateSystems/magic-nix-cache-action@eeabdb0...fc6aace)

---
updated-dependencies:
- dependency-name: DeterminateSystems/magic-nix-cache-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump docker/setup-buildx-action from 3.1.0 to 3.2.0

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@0d103c3...2b51285)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump docker/login-action from 3.0.0 to 3.1.0

Bumps [docker/login-action](https://github.com/docker/login-action) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@343f7c4...e92390c)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump golang from `010f3b3` to `ede158f`

Bumps golang from `010f3b3` to `ede158f`.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump github.com/hashicorp/vault/api from 1.12.1 to 1.12.2

Bumps [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault@v1.12.1...v1.12.2)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump actions/cache from 4.0.1 to 4.0.2

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@ab5e6d0...0c45773)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore: bump actions/dependency-review-action from 4.1.3 to 4.2.3

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.1.3 to 4.2.3.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@9129d7d...0fa40c3)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@csatib02 @akijakya
chore
3a5b915 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix: add temp openbao docker image
57df1ec 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix: remove toolchain
20971ae 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix: add bao container to the ci
c58730c 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix: container image in ci
720d473 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
fix: remove failing test
4570495 
Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: add back test

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: test

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: test

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: test

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: test

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: test

Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
feat: add bao service to ci
0cefffe 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 linked an issue Mar 25, 2024 that may be closed by this pull request
Add openBao test to the CI once released #95
Closed
@csatib02 csatib02 requested a review from akijakya March 25, 2024 19:11
@csatib02
fix(e2e): daemon-mode e2e tests, and examples fixed
bb0be10 
Signed-off-by: Bence Csati <bcsati@cisco.com>

fix(): e2e

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix(): e2e

Signed-off-by: Bence Csati <bcsati@cisco.com>

fix: e2e

Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
ramizpolic requested changes Apr 5, 2024
View reviewed changes
env_store_test.go Show resolved Hide resolved
examples/standalone-tool.md Outdated Show resolved Hide resolved
pkg/provider/bao/client_logger.go Outdated Show resolved Hide resolved
pkg/provider/bao/daemon_secret_renewer.go Show resolved Hide resolved
pkg/provider/bao/bao.go Show resolved Hide resolved
pkg/provider/bao/bao.go Outdated Show resolved Hide resolved
pkg/provider/bao/bao.go Outdated Show resolved Hide resolved
pkg/provider/bao/bao.go Show resolved Hide resolved
env_store.go Show resolved Hide resolved
This was referenced Apr 5, 2024
Open
Merged
Closed
@csatib02
fix: remarks
e4e21f6 
Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
ramizpolic requested changes Apr 5, 2024
View reviewed changes
env_store.go Outdated Show resolved Hide resolved
pkg/internal/utils/client_logger.go Outdated Show resolved Hide resolved
@csatib02
fix: remarks
a7464bd 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 merged commit 746bc73 into main Apr 8, 2024
20 checks passed
@csatib02 csatib02 deleted the feat/add-bao-provider branch April 8, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@csatib02 csatib02

Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 1000+ lines
Projects
Project backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add openBao test to the CI once released OpenBao integration
3 participants
@csatib02 @ramizpolic @akijakya