Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite sync command to work with only the context created on command execution #202

Closed
3 tasks done
csatib02 opened this issue Jun 17, 2024 · 1 comment · Fixed by #215
Closed
3 tasks done

Rewrite sync command to work with only the context created on command execution #202

csatib02 opened this issue Jun 17, 2024 · 1 comment · Fixed by #215
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@csatib02
Copy link
Member

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.
  • I agree to follow the Code of Conduct.

Version

v0.1.3

Expected Behavior

command.ExecuteContext(context.Background()) should create the context, and it should be retrievable with command.Context().

Actual Behavior

Currently the NewSyncCMD function runs init() and run() and after that the sync command is executed, therefore we cannot use command.ExecuteContext(context.Background()) to create a context, and then use it elsewhere with command.Context().

Steps To Reproduce

No response

Logs

No response

Additional Information

No response

@csatib02 csatib02 added the kind/bug Categorizes issue or PR as related to a bug. label Jun 17, 2024
@csatib02
Copy link
Member Author

Tracking: #205 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant